Add support for Safari#681
Conversation
TODO: Setup browser extension project in Apple developer
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
Thanks a lot!
Looks like this PR contains a few unrelated/unnecessary or otherwise strange changes (AI generated??). Can you please revise this, or at least explain the need for the changes.
The main issue is the whole scripts/makefile setup. In the wxt world, you solve this by "modules" that hook into the build progress and modify/postprocess the output. You might be able to reuse https://github.com/rxliuli/wxt-module-safari-xcode or at least get inspiration how its done.
| github_token: ${{ secrets.RELEASE_PR_TOKEN }} | ||
| branch: ${{ fromJson(steps.release.outputs.pr).headBranchName }} | ||
|
|
||
| safari-package: |
There was a problem hiding this comment.
Why not merge this below with the publish workflow?
There was a problem hiding this comment.
Also instead of maintaining our version of publish/notarize/sign/whatever apple wants, can we reuse existing scripts please. Say https://github.com/rxliuli/safari-webext-publish-action.
There was a problem hiding this comment.
This is still unresolved. It should be just another matrix-option for macos/safari in the existing publish workflow.
| - name: Run tests | ||
| run: pnpm test | ||
|
|
||
| safari-build: |
There was a problem hiding this comment.
Same here, this duplication is not easy to maintain.
| <span id="connectionStatusHttp">Testing connection...</span> | ||
| </div> | ||
| </div> | ||
| <div class="grid-container"> |
There was a problem hiding this comment.
What's the point of these changes here in the options dialog. They seem to be independent/unrelated to the macos stuff. Extract to new PR?
There was a problem hiding this comment.
Used for testing native messaging
There was a problem hiding this comment.
I added a screenshot in the PR. This is especially relevant for mac as we will be able to see the native messagings logs now in the konsole app of mac if it works
| }, | ||
| description: | ||
| "The JabRef browser extension imports new bibliographic information directly from the browser into JabRef.", | ||
| developer: { |
Can you do this please, and then configure the securities in the gh actions to actually be able to test the publish/notarize workflow. |
Add workflow for maual safari tests
* origin/main: Add workflow for maual tests
set unique safari build number
* origin/main: set unique safari build number
|
Uploading to apple app store connect works now. |
2 participants
Edit//:
App store deployment is configured. Once we have a working build we need to upload it and get approval from apple
TODO: Configure secrets
Tested locally both with latest JabRef dev version on macOS 15.7.7
Some of the scripts were copied over from Browser Extensionn fresh